Breaking change: ndb KeyProperties should be externalised as Global IDs

graphql-python / graphene-gae

GraphQL Support for Google AppEngine [DEPRECATED - Looking for maintainers]

http://docs.graphene-python.org/projects/gae/en/latest/

BSD 3-Clause "New" or "Revised" License

117 stars 14 forks source link

Breaking change: ndb KeyProperties should be externalised as Global IDs #16

Closed ekampf closed 8 years ago

ekampf commented 8 years ago

We should never externalise internal NDB key values. It doesn't make sense. GraphQL Nodes IDs are in a _globalid format (a base64 encoded :). It only makes sense that model properties that expose ids of other objects use the same format.

Otherwise the APIs consumer will have to know when to convert from global_id to key and the opposite.

coveralls commented 8 years ago

Changes Unknown when pulling 3dfa734161fdef0dff251cbb4fdffa0cf9ead01c on feature/fix_key_property_behavior into \ on master**.

coveralls commented 8 years ago

Changes Unknown when pulling 05e87d47c5f7ad286159aaa72b21071e1508eaa4 on feature/fix_key_property_behavior into \ on master**.