Closed ekampf closed 8 years ago
As a suggestion, as both id's are Strings and focus on the identity of a store key maybe you can cover both use cases with just one field that receives an argument.
Something like:
store_id = graphene.String(ndb=graphene.Boolean())
def resolve_store_id(root, args, context, info):
if args.get('ndb'):
return store_key.id()
return store_key.urlsafe()
😉
@syrusakbary thats way nicer!
@syrusakbary WDYT now?
Looks good!
Coverage decreased (-1.8%) to 96.543% when pulling 9947f38b1add68c9d31fff773df8131e10adf7f3 on feature/expose_ndb_ids into f354e7c7619482dfac96c530d17784e8be5982d1 on master.