graphql-python / graphene-pydantic

Integrate GraphQL with your Pydantic models
Other
224 stars 45 forks source link

json string support? #37

Closed hyusetiawan closed 3 years ago

hyusetiawan commented 4 years ago

pydantic has support for Json field, i think that maps directly to https://docs.graphene-python.org/en/latest/_modules/graphene/types/json/ of graphene?

necaris commented 4 years ago

@hyusetiawan it's not clear to me which JSON field support you mean in Pydantic? Especially since this is something the GraphQL spec specifically discourages people from using, I'm not keen to add support for it unless someone has a clear need for it.

necaris commented 3 years ago

Since this hasn't been active in >3 months, I'm closing it; please reopen if you have more comments!

eplatonoff commented 3 years ago

@necaris We have a dynamic survey definition schema in one field beside other data in the model. So I can try to implement the PR for JSON support if you don't mind.

necaris commented 3 years ago

Please do, I'd love to see what you are thinking.

Eugene Platonov @.***> writes:

@necaris We have a dynamic survey definition schema in one field beside other data in the model. So I can try to implement the PR for JSON support if you don't mind.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

-- Rami Chowdhury A mind all logic is like a knife all blade - it makes the hand bleed that uses it. -- Rabindranath Tagore