Simplify import of version number

graphql-python / graphene-sqlalchemy

Graphene SQLAlchemy integration

http://docs.graphene-python.org/projects/sqlalchemy/en/latest/

MIT License

980 stars 226 forks source link

Simplify import of version number #299

Closed dotcs closed 3 years ago

dotcs commented 3 years ago

I found the previous implementation to import the version number too complex, but maybe I have missed something here? If possible this should be simplified.

bim9262 commented 3 years ago

The reason that's it's written the way it is is that graphene_sqlalchemy/init.py imports things that will be installed by setup.py, but aren't installed at the time that you tried to do the import.

dotcs commented 3 years ago

Alright, thanks for the clarification. I'll close this PR then.