search

graphql-python / graphene-sqlalchemy

Graphene SQLAlchemy integration
http://docs.graphene-python.org/projects/sqlalchemy/en/latest/
MIT License
975 stars 225 forks source link

BUG: Out of Sync with graphql-relay > 3.1 #329

Closed ed-turner closed 2 years ago

ed-turner commented 2 years ago

This is related to the import graphql_relay.connection.arrayconnection in graphene_sqlalchemy.fields.SQLAlchemyConnectionField.

To reproduce:

  1. pip install graphql-relay==3.1.0
  2. Run from graphene_sqlalchemy.fields import SQLAlchemyConnectionField
  3. You will get an import module error for graphql_relay.connection.arrayconnection

One suggestion is to either make specific requirements for graphql-relay in the install requirements or update the imports in the 3.0 release.

Cito commented 2 years ago

There will be a patch release of graphql-relay 3.1 for backward compatibility today, but it should also be fixed here by importing from the top level of graphql-relay.

Cito commented 2 years ago

A patch-release graphql-relay 3.1.5 has been released now and a fix for graphene-sqlalchemy has been posted as PR #330.

erikwrede commented 2 years ago

I've just merged the PR, this should be fixed once someone with PyPi access pushes a release!

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics referencing this issue.