Closed jendrikjoe closed 1 year ago
Base: 96.36% // Head: 96.36% // Increases project coverage by +0.00%
:tada:
Coverage data is based on head (
6b036ac
) compared to base (d3a4320
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Sorry for the late reply. I have received multiple messages about this, so I am considering making changes to the type conversion system introduced in #371 so that we keep supporting the conversion of subclasses of registered classes. This adds a lot of convenience since every driver has custom subtypes for bigint, integer and others. Please check out #377 to see if that fixes your issues and give me some feedback ☺️ I will add the necessary tests tomorow.
Sorry for the late reply. I have received multiple messages about this, so I am considering making changes to the type conversion system introduced in #371 so that we keep supporting the conversion of subclasses of registered classes. This adds a lot of convenience since every driver has custom subtypes for bigint, integer and others. Please check out #377 to see if that fixes your issues and give me some feedback ☺️ I will add the necessary tests tomorow.
No worries. Solving this in a generic way definitely seems reasonable 👍 Will close this one in favor of #377 👍
With the merge of #371, the conversion of Decimal columns broke for us. I added a decimal column as we are creating them to the test model reproducing it and a possible fix, by registering the type to the converter.