graphql-python / graphene-sqlalchemy

Graphene SQLAlchemy integration
http://docs.graphene-python.org/projects/sqlalchemy/en/latest/
MIT License
980 stars 226 forks source link

Prioritize custom type conversion over standard conversions #390

Open PaulSchweizer opened 1 year ago

PaulSchweizer commented 1 year ago

As discussed with @erikwrede we have to make sure that we prioritize registered custom type conversions over the defaults.

Example:

This:

from sqlalchemy_utils import JSONType

@convert_sqlalchemy_type.register(JSONType)
def convert_column_to_json(*args, **kwargs):
    return graphene.types.generic.GenericScalar

will result in a JSONString field instead of a GenericScalar

adiberk commented 6 months ago

This is pretty important, nice catch