erikwrede
commented
5 months ago Hey, thanks for the report. Can you share a little more about your use case, maybe with a code example to understand your situation better? 😊
For public repositories you can always open a PR from your fork by clicking new PR on the main Repo and selecting your fork branch: https://github.com/graphql-python/graphene/compare
Or simply via github cli, running gh pr create.
What is the current behavior? As of 3.1.0, the
resolve_typemethod on Interfaces and Unions no longer supports returning the GraphQL Type as a string as opposed to the actual Graphene Type. I think this might be an unintended regression from https://github.com/graphql-python/graphene/pull/1421.What is the expected behavior? Our project heavily depends on resolve_type returning a string for the GraphQL Type as opposed to the Graphene Type that implements it.
What is the motivation / use case for changing the behavior? While it's possible to refactor most of our code to return the Graphene Type, there are some cases where it's very difficult to break circular imports. The reason for that is that some of our implementations of the
resolve_typemethod delegates to returning a property of an Enum and the Enum definition can't reference the Graphene Type because the Graphene Type references the enum.Please tell us about your environment:
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow) I created https://github.com/perlow/graphene/pull/1 in a fork. I don't have write permission the repo to request a merge. If this looks reasonable, I can add a unit test for the behavior.