search

graphql-python / graphql-core-legacy

GraphQL base implementation for Python (legacy version – see graphql-core for the current one)
MIT License
374 stars 183 forks source link

Add traceback to errors from failed promises #240

Closed Cito closed 5 years ago

Cito commented 5 years ago

The stack attribute of GraphQLLocatedErrors was not set for errors that resulted from asynchronous resolvers.

This PR adds a unit test for this problem and a solution that works with Python >= 3 and solves #237.

For Python 2 this problem is not yet solved, and may be never solved, because dealing with stack traces is much more difficult there.

jkimbo commented 5 years ago

@Cito merge whenever you're ready