search

graphql-python / graphql-server

This is the core package for using GraphQL in a custom server easily
MIT License
120 stars 72 forks source link

Don't use executor in run_http_query when return_promise=True #33

Closed blazewicz closed 4 years ago

blazewicz commented 4 years ago

fixes #32

ItsAshleyJ182 commented 4 years ago

This all looks good to me, I discovered this issue in my application as well.

@Cito I notice you're one of the main contributors to this project after @syrusakbary opened it up to the community, are there any contributing/review guidelines we should be following?

ItsAshleyJ182 commented 4 years ago

@Cito is there anyone else who has write access to this repository? We should really address this issue

Cito commented 4 years ago

@banjoanderson was swamped with work - will have a look later today.

Cito commented 4 years ago

Thanks a lot for working on this. I will create a 1.2 release containing this fix.

Cito commented 4 years ago

Version 1.2.0 has been released now.