graphql-python / graphql-server

This is the core package for using GraphQL in a custom server easily
MIT License
120 stars 72 forks source link

Migration to graphql-core-v3 #36

Closed KingDarBoja closed 4 years ago

KingDarBoja commented 4 years ago

Based on @Cito branch as stated at #20 and as part of the refactoring and merge steps discussed at the Slack channel plus #34, this PR aims to make graphql-server compatible with latest graphql-core version.

@jkimbo this one is ready for review!

KingDarBoja commented 4 years ago

Ummm, so weird, the re-added tests didn't passed although those did locally.

EDIT Fixed both tests because missing period on the graphql-core error message (which got fixed on v3.1.0).

KingDarBoja commented 4 years ago

@jkimbo I have no idea what's going on but removing the @mark.asyncio on the asyncio test will make it pass 🤔