search

graphql-query-rewriter / core

Seamlessly turn breaking GraphQL changes into non-breaking changes
https://graphql-query-rewriter.github.io/core
MIT License
409 stars 16 forks source link

Ensure that arrays are properly supported #29

Closed Sytten closed 3 years ago

Sytten commented 3 years ago

The latest release broke the output for arrays (basically all arrays got mapped to an array of arrays). I started by fixing that and then I realized it would require a large rewrite to really support arrays properly. So this doesn't introduce a breaking change per the interface, but it does break the contract of rewriteResponse. I added test cases so this cannot happen again.

Sytten commented 3 years ago

@chanind @gregbty Please review that this doesnt break your intended workflow for the field name rewrite.

chanind commented 3 years ago

:tada: This PR is included in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Sytten commented 3 years ago

@chanind I would change the message in the release to explain the bug for future reference.

chanind commented 3 years ago

crap, I thought that semantic-release would have done that automatically. Let me see if I can change it after the fact...

chanind commented 3 years ago

👍 OK should be fixed!