search

graphql-rust / juniper

GraphQL server library for Rust
Other
5.72k stars 425 forks source link

Abstract (start, end) from Spanning struct into new struct Span #1207

Closed audunhalland closed 1 year ago

audunhalland commented 1 year ago

This makes it easier to treat the source region (the Span) separately from the spanned item in Spanning.

audunhalland commented 1 year ago

The checkbox isn't visible for me. Could it be because the fork is owned by an organization in which I'm not an administrator? :thinking:

Perhaps it's better if I re-create the PR from my personal fork.

audunhalland commented 1 year ago

New PR up at https://github.com/graphql-rust/juniper/pull/1208 (from a my personal fork). Sorry for the noise :crying_cat_face:

The "Allow edits" github bug is discussed here: https://github.com/orgs/community/discussions/5634

tyranron commented 1 year ago

@audunhalland thanks!