Fix handling GET request in `rocket` example (#1098) - Githubissues

graphql-rust / juniper

GraphQL server library for Rust

Other

5.62k stars 416 forks source link

Fix handling GET request in `rocket` example (#1098) #1223

Closed tyranron closed 7 months ago

tyranron commented 7 months ago

Resolves #1098

Synopsis

See https://github.com/graphql-rust/juniper/issues/1098#issuecomment-1825851417:

The example, however, is really broken. Rather than having
#[rocket::get("/graphql?<request>")]
attribute, it should have
#[rocket::get("/graphql?<request..>")]

Solution

Fix the routing in the example.

Additionally

Some housekeeping work:

[x] Move integration HTTP tests into a separate file.
[x] Test both sync and async rocket in integration HTTP tests.
[x] Improve documentation, providing more examples.
[x] Improve and rename the example.