graphql-rust / juniper

GraphQL server library for Rust
Other
5.62k stars 416 forks source link

Refactor code to remove async move closure which may result in double… #1256

Open jawang94 opened 2 months ago

jawang94 commented 2 months ago

Closes #820

I did not detect any apparent double boxing issues here however I refactored the code to use the custom AsyncValueFuture enum and eliminate the unnecessary async move closure. This is my first contribution here - all cargo tests passed however the test.book failed with some strange error about the dataloader crate which seems unrelated.

P.S. I am new to rust and snooping around for real-world practice so please advise me if I've made mistakes or missed something! Thank you in advance and hope to contribute more in the future!