I did not detect any apparent double boxing issues here however I refactored the code to use the custom AsyncValueFuture enum and eliminate the unnecessary async move closure. This is my first contribution here - all cargo tests passed however the test.book failed with some strange error about the dataloader crate which seems unrelated.
P.S. I am new to rust and snooping around for real-world practice so please advise me if I've made mistakes or missed something! Thank you in advance and hope to contribute more in the future!
Closes #820
I did not detect any apparent double boxing issues here however I refactored the code to use the custom
AsyncValueFuture
enum and eliminate the unnecessaryasync move
closure. This is my first contribution here - allcargo test
s passed however thetest.book
failed with some strange error about thedataloader
crate which seems unrelated.P.S. I am new to rust and snooping around for real-world practice so please advise me if I've made mistakes or missed something! Thank you in advance and hope to contribute more in the future!