Closed sgoll closed 2 months ago
@sgoll
The new types are hidden behind feature flag
jiff-tz
because they require enabling thestd
feature flag for thejiff
crate (which is not necessary for the remaining Jiff date/time types introduced in #1271).
I think this is redundant. juniper
at the moment is not capable of acting in no_std
, so you could just add that feature and don't bother.
I think this is redundant.
juniper
at the moment is not capable of acting inno_std
, so you could just add that feature and don't bother.
I removed the feature flag and merged the master
branch into this PR. With the recent commit that removed the panic in TimeZone
, and the additions to your integration test, this is now ready for review and/or merge, I think.
I am not sure whether the two failing tests in the last CI run are related to my changes.
Failures Re unrelated. Thanks again!
Description
This is a follow-up to #1271 and adds integration for the following Jiff date/time types:
Zoned
to GraphQL scalarZonedDateTime
[^1]tz::TimeZone
to GraphQL scalarTimeZoneOrUtcOffset
[^2], and to GraphQL scalarTimeZone
with a newtypetz::Offset
to GraphQL scalarUtcOffset
[^1]: This GraphQL scalar is not documented at https://graphql-scalars.dev but we can introduce it here as laid out in https://github.com/graphql-rust/juniper/issues/1270#issuecomment-2291041828.
[^2]: This GraphQL scalar does not exist yet either. It is the union of GraphQL scalars
TimeZone
andUtcOffset
.~The new types are hidden behind feature flag
jiff-tz
because they require enabling thestd
feature flag for thejiff
crate (which is not necessary for the remaining Jiff date/time types introduced in #1271).~In addition, the
jiff
crate itself must be installed either with the default feature flags or with explicit feature flags that make the Time Zone Database available as explained injiff
time zone features.Closes #1270