search

graphql / composite-schemas-spec

MIT License
26 stars 9 forks source link

Make Overview less prescriptive #23

Closed SimonSapin closed 5 months ago

SimonSapin commented 7 months ago

This "must" came across as opinionated on what the reader should do, rather than what composition can empower them to do.

SimonSapin commented 7 months ago

This change is smaller than the diff suggests but prettier doesn’t seem to support something like https://sembr.org/ for prose wrapping.

SimonSapin commented 7 months ago

Pushed changes that can be squashed

SimonSapin commented 7 months ago

@benjie At the moment the PR says “2 workflows awaiting approval”, is there something else I need to do?

benjie commented 7 months ago

@michaelstaib Thoughts?

michaelstaib commented 5 months ago

The change is wrong in my mind. The intend is that you can change the general service structure but this must not break the contract with the client.