graphql / composite-schemas-spec

MIT License
26 stars 9 forks source link

Combine @is and @provides #28

Closed smyrick closed 5 months ago

smyrick commented 5 months ago

These two directives are functionally doing the same thing we just limit them to different use cases with the directive locations.

They both tell the query planner that if you go through this path some of the data you will get back can be sourced either from an argument or it will be provided by the subgraph

I am open for discussion of not merging them. But at second glance they do seem very similar. It also helps with the short and unclear name of @is

michaelstaib commented 5 months ago

I think this looks great and would reduce cognitive complexity.

dariuszkuc commented 5 months ago

I don't think those two directives should be merged

michaelstaib commented 5 months ago

@dariuszkuc we discussed it in the wg last week and came to the same conclusion. I am closing this PR