search

graphql / composite-schemas-spec

MIT License
30 stars 9 forks source link

“Is” directive with mutually-exclusive arguments is smelly #52

Open gmac opened 1 month ago

gmac commented 1 month ago

From https://github.com/graphql/composite-schemas-spec/blob/main/spec/Section%202%20--%20Source%20Schema.md#is.

If the arguments of “is” are mutually exclusive and fail composition in tandem, then why are they a single directive? Making them separate directives would make this impossible and push developers into the pit of success.

benjie commented 1 month ago

Alternatively; use @oneOf?

glen-84 commented 1 month ago

It's a single FieldSelectionMap argument in this PR.