search

graphql / dataloader

DataLoader is a generic utility to be used as part of your application's data fetching layer to provide a consistent API over various backends and reduce requests to those backends via batching and caching.
MIT License
12.89k stars 515 forks source link

Fixes #294. #321

Closed thekevinbrown closed 1 year ago

thekevinbrown commented 1 year ago

This PR fixes #294.

It should be noted that this also amends the max batch size respects cached results test. A side effect of this change is that it slightly changes the moment when the first batch is resolved. DataLoader still does respect cached results, and the load call in that test is still only called to request 2, so I didn't think this was a problem.

Happy to do this a different / better way if anyone has any ideas, but this seemed the most straightforward to me.

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

thekevinbrown commented 1 year ago

I've now signed the CLA ^.

saihaj commented 1 year ago

can you run yarn changeset and add a patch and explain this change. You can read more about changeset here

thekevinbrown commented 1 year ago

No worries!

That's done, and I also created #322 to add this info to CONTRIBUTING.md for the future.

saihaj commented 1 year ago

awesome! @thekevinbrown I recently have been running into some npm publish issue. I will try to spend sometime this week so we can get this published

thekevinbrown commented 1 year ago

No worries, I'm working off my own local copy anyway so no stress there.

If there's anything I can do to help just let me know!

thekevinbrown commented 1 year ago

Hey @saihaj, just wanted to check in and see how the publish is going. Is there anything I can do to help?

saihaj commented 1 year ago

I am waiting for @leebyron to update some settings in GH org

thekevinbrown commented 1 year ago

@leebyron, any progress?

leebyron commented 1 year ago

I'm not sure why version deploy is broken, but I added @saihaj as an NPM publisher so hopefully you can help debug

saihaj commented 1 year ago

yes I received NPM access thanks @leebyron will try to get a release out sometime this week @thekevinbrown

thekevinbrown commented 1 year ago

@saihaj, sorry to pester, just want to check in and see if there's anything I can do to help?

saihaj commented 1 year ago

@saihaj, sorry to pester, just want to check in and see if there's anything I can do to help?

let's use this issue to chat update since there are a few things that we will rollout https://github.com/graphql/dataloader/issues/328#issuecomment-1413269453

thekevinbrown commented 1 year ago

Awesome, thanks for your work @saihaj! Much appreciated.