graphql / graphiql

GraphiQL & the GraphQL LSP Reference Ecosystem for building browser & IDE tools.
MIT License
16.11k stars 1.73k forks source link

[v4] show tabs even there is only 1 tab #3713

Closed dimaMachina closed 3 months ago

dimaMachina commented 3 months ago

it's hard to find Add tab when there is only 1 tab

deploy-preview-3685--graphiql-test netlify app__query=%23%20Welcome%20to%20GraphiQL%0A%23%0A%23%20GraphiQL%20is%20an%20in-browser%20tool%20for%20writing%2C%20validating%2C%20and%0A%23%20testing%20GraphQL%20queries %0A%23%0A%23%20Type%20quer

I think we should follow Chrome UX and show tabs even when there is 1 tab

deploy-preview-3713--graphiql-test netlify app__query=%23%20Welcome%20to%20GraphiQL%0A%23%0A%23%20GraphiQL%20is%20an%20in-browser%20tool%20for%20writing%2C%20validating%2C%20and%0A%23%20testing%20GraphQL%20queries %0A%23%0A%23%20Type%20quer

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: e94f5c9b7a9e9996c76f4407ee258aac87c98c56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | graphiql | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (1a6d63d) to head (e94f5c9).

Files Patch % Lines
packages/graphiql/src/components/GraphiQL.tsx 75.00% 4 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/graphql/graphiql/pull/3713/graphs/tree.svg?width=650&height=150&src=pr&token=XdBgmoWsyv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql)](https://app.codecov.io/gh/graphql/graphiql/pull/3713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql) ```diff @@ Coverage Diff @@ ## graphiql-v4 #3713 +/- ## =============================================== - Coverage 67.60% 67.57% -0.03% =============================================== Files 121 121 Lines 6960 6955 -5 Branches 2244 2222 -22 =============================================== - Hits 4705 4700 -5 Misses 2238 2238 Partials 17 17 ``` | [Files](https://app.codecov.io/gh/graphql/graphiql/pull/3713?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql) | Coverage Δ | | |---|---|---| | [packages/graphiql/src/components/GraphiQL.tsx](https://app.codecov.io/gh/graphql/graphiql/pull/3713?src=pr&el=tree&filepath=packages%2Fgraphiql%2Fsrc%2Fcomponents%2FGraphiQL.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhpcWwvc3JjL2NvbXBvbmVudHMvR3JhcGhpUUwudHN4) | `77.72% <75.00%> (-0.52%)` | :arrow_down: |
github-actions[bot] commented 3 months ago

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.