graphql / graphiql

GraphiQL & the GraphQL LSP Reference Ecosystem for building browser & IDE tools.
MIT License
16.11k stars 1.73k forks source link

[graphiql] fix placeholder `⌘ K` in doc explorer search input for non mac devices, replace by `Ctrl K` #3751

Closed dimaMachina closed 2 months ago

dimaMachina commented 2 months ago

fixes https://github.com/graphql/graphiql/issues/3436

https://github.com/user-attachments/assets/8baa492d-e9f2-45bd-b6db-12e33700e7fc

https://github.com/user-attachments/assets/7fced4de-c27b-4042-8b39-752d5f83d1ec

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 459dd47aed3eae6774ebed4db730c247e67c25d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ------------------ | ----- | | codemirror-graphql | Patch | | @graphiql/react | Patch | | cm6-graphql | Patch | | graphiql | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.32%. Comparing base (1a561b3) to head (459dd47). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/graphql/graphiql/pull/3751/graphs/tree.svg?width=650&height=150&src=pr&token=XdBgmoWsyv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql)](https://app.codecov.io/gh/graphql/graphiql/pull/3751?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql) ```diff @@ Coverage Diff @@ ## main #3751 +/- ## ========================================== - Coverage 65.33% 65.32% -0.01% ========================================== Files 121 122 +1 Lines 7007 7003 -4 Branches 2262 2260 -2 ========================================== - Hits 4578 4575 -3 + Misses 2412 2411 -1 Partials 17 17 ``` | [Files](https://app.codecov.io/gh/graphql/graphiql/pull/3751?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql) | Coverage Δ | | |---|---|---| | [...ackages/codemirror-graphql/src/utils/jump-addon.ts](https://app.codecov.io/gh/graphql/graphiql/pull/3751?src=pr&el=tree&filepath=packages%2Fcodemirror-graphql%2Fsrc%2Futils%2Fjump-addon.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvY29kZW1pcnJvci1ncmFwaHFsL3NyYy91dGlscy9qdW1wLWFkZG9uLnRz) | `2.59% <100.00%> (ø)` | | | [packages/graphiql-react/src/editor/common.ts](https://app.codecov.io/gh/graphql/graphiql/pull/3751?src=pr&el=tree&filepath=packages%2Fgraphiql-react%2Fsrc%2Feditor%2Fcommon.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhpcWwtcmVhY3Qvc3JjL2VkaXRvci9jb21tb24udHM=) | `100.00% <ø> (ø)` | | | [.../graphiql-react/src/explorer/components/search.tsx](https://app.codecov.io/gh/graphql/graphiql/pull/3751?src=pr&el=tree&filepath=packages%2Fgraphiql-react%2Fsrc%2Fexplorer%2Fcomponents%2Fsearch.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhpcWwtcmVhY3Qvc3JjL2V4cGxvcmVyL2NvbXBvbmVudHMvc2VhcmNoLnRzeA==) | `61.11% <100.00%> (+0.36%)` | :arrow_up: | | [packages/graphiql-react/src/utility/is-macos.ts](https://app.codecov.io/gh/graphql/graphiql/pull/3751?src=pr&el=tree&filepath=packages%2Fgraphiql-react%2Fsrc%2Futility%2Fis-macos.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhpcWwtcmVhY3Qvc3JjL3V0aWxpdHkvaXMtbWFjb3MudHM=) | `100.00% <100.00%> (ø)` | | | [packages/graphiql/src/components/GraphiQL.tsx](https://app.codecov.io/gh/graphql/graphiql/pull/3751?src=pr&el=tree&filepath=packages%2Fgraphiql%2Fsrc%2Fcomponents%2FGraphiQL.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhpcWwvc3JjL2NvbXBvbmVudHMvR3JhcGhpUUwudHN4) | `78.57% <100.00%> (+0.15%)` | :arrow_up: |
github-actions[bot] commented 2 months ago

The latest changes of this PR are available as canary in npm (based on the declared changesets):

cm6-graphql@0.1.1-canary-52a5839f.0
codemirror-graphql@2.1.1-canary-52a5839f.0
graphiql@3.7.1-canary-52a5839f.0
@graphiql/plugin-code-exporter@3.1.3-canary-52a5839f.0
@graphiql/plugin-explorer@3.2.3-canary-52a5839f.0
@graphiql/react@0.26.2-canary-52a5839f.0