graphql / graphiql

GraphiQL & the GraphQL LSP Reference Ecosystem for building browser & IDE tools.
MIT License
16.11k stars 1.73k forks source link

feat(graphql-language-service): Support for experimental fragment arguments #3761

Open JoviDeCroock opened 2 months ago

JoviDeCroock commented 2 months ago

This is a work in progress branch for:

Being able to finish auto-complete and validation will depend on getting an alpha published as we need parse to behave well. The steps included in finishing this would be to add an auto-complete step for fragment arguments where we look up all fragments and check the available arguments so we can auto-complete.

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 975d10113528cc7c4e0abc2a5cbeb8b342239760

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.31%. Comparing base (ab48c83) to head (975d101).

Files with missing lines Patch % Lines
...graphql-language-service/src/parser/getTypeInfo.ts 0.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/graphql/graphiql/pull/3761/graphs/tree.svg?width=650&height=150&src=pr&token=XdBgmoWsyv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql)](https://app.codecov.io/gh/graphql/graphiql/pull/3761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql) ```diff @@ Coverage Diff @@ ## main #3761 +/- ## ========================================== - Coverage 65.32% 65.31% -0.02% ========================================== Files 122 122 Lines 7003 7006 +3 Branches 2260 2262 +2 ========================================== + Hits 4575 4576 +1 - Misses 2411 2413 +2 Partials 17 17 ``` | [Files with missing lines](https://app.codecov.io/gh/graphql/graphiql/pull/3761?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql) | Coverage Δ | | |---|---|---| | [...ervice/src/interface/getAutocompleteSuggestions.ts](https://app.codecov.io/gh/graphql/graphiql/pull/3761?src=pr&el=tree&filepath=packages%2Fgraphql-language-service%2Fsrc%2Finterface%2FgetAutocompleteSuggestions.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhxbC1sYW5ndWFnZS1zZXJ2aWNlL3NyYy9pbnRlcmZhY2UvZ2V0QXV0b2NvbXBsZXRlU3VnZ2VzdGlvbnMudHM=) | `85.86% <100.00%> (+0.03%)` | :arrow_up: | | [...kages/graphql-language-service/src/parser/Rules.ts](https://app.codecov.io/gh/graphql/graphiql/pull/3761?src=pr&el=tree&filepath=packages%2Fgraphql-language-service%2Fsrc%2Fparser%2FRules.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhxbC1sYW5ndWFnZS1zZXJ2aWNlL3NyYy9wYXJzZXIvUnVsZXMudHM=) | `95.45% <ø> (ø)` | | | [...guage-service/src/utils/validateWithCustomRules.ts](https://app.codecov.io/gh/graphql/graphiql/pull/3761?src=pr&el=tree&filepath=packages%2Fgraphql-language-service%2Fsrc%2Futils%2FvalidateWithCustomRules.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhxbC1sYW5ndWFnZS1zZXJ2aWNlL3NyYy91dGlscy92YWxpZGF0ZVdpdGhDdXN0b21SdWxlcy50cw==) | `95.23% <ø> (ø)` | | | [...graphql-language-service/src/parser/getTypeInfo.ts](https://app.codecov.io/gh/graphql/graphiql/pull/3761?src=pr&el=tree&filepath=packages%2Fgraphql-language-service%2Fsrc%2Fparser%2FgetTypeInfo.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphql#diff-cGFja2FnZXMvZ3JhcGhxbC1sYW5ndWFnZS1zZXJ2aWNlL3NyYy9wYXJzZXIvZ2V0VHlwZUluZm8udHM=) | `82.31% <0.00%> (-1.14%)` | :arrow_down: |