Closed simmerer closed 2 weeks ago
Latest commit: 91fde2bf7bb3eac9788e568b536d931638a9da2e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
thanks @simmerer ! I am currently in the process of migrating most of this logic to a lower service level, and will be removing this usage of caller
. this will be very helpful for the time being, thank you!
noting that this will cause bugs when users accidentally double tap the execute button, or execute multiple queries quickly in serial, as the usage of caller
is meant to also uniquely identify the request being executed, so that previous in-flight requests can be cancelled iirc. but this is something I am already accommodating for in the rewrite using unique IDs, and for now I think we can ensure the button is fully disabled
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 65.32%. Comparing base (
7a59187
) to head (91fde2b
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
packages/graphiql-react/src/utility/context.ts | 0.00% | 1 Missing :warning: |
I'm going to call this good to go for now, as the full resolution will be introduced in 4.x soon! thank you!
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Deprecated_caller_or_arguments_usage
While it's helpful during development to have as much information as possible about which component doesn't have the necessary context, it's very not helpful to have the error message itself throw a blocking error due to this deprecated usage 😅
In a future PR, it might be nice to rename the
caller
argument found throughout GraphiQL packages to something likecallerFn
for clarity, making it clear at a glance that it's a custom arg and not an attempt to accessFunction.prototype.caller
.