graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
20.02k stars 2.02k forks source link

Document or lint as much as possible of our code style #2604

Open IvanGoncharov opened 4 years ago

IvanGoncharov commented 4 years ago

We have a pretty uniform codebase which is very important for the reference implementation. That said I the price that we pay for this it's extremely hard to start contributing since you get a huge amount of review comments in your first PR. Also, it gave the wrong incentives to maintainers (including myself) to just rewriting PR from scratch since it was way easier than to explain what's wrong with the code.

Don't think that there is any silver bullet but we can do a couple of things:

I think a good strategy would be to first work on common issues that most of the first-time contributors struggling with:

IvanGoncharov commented 4 years ago
IvanGoncharov commented 4 years ago
IvanGoncharov commented 4 years ago
IvanGoncharov commented 4 years ago
IvanGoncharov commented 3 years ago