search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
20k stars 2.01k forks source link

Performance of stack traces in errors results in high response latency (>1 second) #4028

Open ajhenry opened 4 months ago

ajhenry commented 4 months ago

Great work y'all are doing here! We've run into a bit of a snag dealing with errors and stack traces.

The problem: As bundle size increases, the duration of calculating a stack trace with source maps of an error thrown during resolver execution takes more time to compute.

We narrowed down the culprit to the following check: https://github.com/graphql/graphql-js/blob/9c90a23dd430ba7b9db3d566b084e9f66aded346/src/error/GraphQLError.ts#L144-L158

We did a flame graph for an error thrown and this resulted in the following:

Image Image

It takes this amount of time regardless of which resolver throws an error.

We currently bundle our server (along with tree-shaken dependencies) in a single file so we can upload it to a lambda. We are at around 76MB for our total bundled file which is not great (😟) but still very usable for us in production.

Our workaround right now is to explicitly set captureStackTrace and bypass having to perform this calculation. This decreases the execution time from 1154ms to 20ms. However, we are left with no stack traces.

Any suggestions or help would be greatly appreciated, thanks!

yaacovCR commented 4 months ago

Duplicate of #2800 ? That issue suggests disabling source maps?