perf: use undefined for empty

graphql / graphql-js

A reference implementation of GraphQL for JavaScript

http://graphql.org/graphql-js/

MIT License

20.1k stars 2.03k forks source link

perf: use undefined for empty #4046

Closed yaacovCR closed 6 months ago

yaacovCR commented 7 months ago

As convention, we will lazily instantiate arrays/sets when adding the first item.

This applies to arrays/sets on execution/incremental context, as well as the second member of the GraphQLWrappedResult tuple holding the array of incremental data records.

netlify[bot] commented 7 months ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name	Link
Latest commit	37f6e882a63446429028a0ae8b5910ca56e7896a
Latest deploy log	https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/663bd21e5a222a0008e8a345
Deploy Preview	https://deploy-preview-4046--compassionate-pike-271cb3.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 7 months ago

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM

yaacovCR commented 7 months ago

yaacovCR commented 6 months ago

took out dependence on #4053

graphql / graphql-js

perf: use undefined for empty #4046

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Deploy Preview for compassionate-pike-271cb3 ready!