search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
20.04k stars 2.02k forks source link

use try-catch to simplify instanceOf checks #4079

Closed yaacovCR closed 5 months ago

yaacovCR commented 5 months ago

for platforms where process.env is not globally accessible and defined, just return true

bundlers should have an easy time just replacing process.env.NODE_ENV without any qualifiers

netlify[bot] commented 5 months ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 5cfec3453ca65dc0e4958231a8a269969b225f9c
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6634aadb0cf0da000860d512
Deploy Preview https://deploy-preview-4079--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 5 months ago

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM
yaacovCR commented 5 months ago

Closing, this does not seem so tree-shakable, see #4075.