graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
20.1k stars 2.03k forks source link

Introduce astFromValueUntyped and handle object values within astFromValue correctly #4087

Closed ardatan closed 1 month ago

ardatan commented 6 months ago

Fixes https://github.com/graphql/graphql-js/issues/4085 Closes https://github.com/graphql/graphql-js/pull/4086

This PR introduces a new function called astFromValueUntyped that creates an AST without a type. This function is needed because if a custom scalar returns an object type, it needs to be serialized without a type.

netlify[bot] commented 6 months ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit fae69d467b0ff8f9607a6b76b3f41b11ee90200d
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/663b8fa89fe2d300083c4310
Deploy Preview https://deploy-preview-4087--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 6 months ago

Hi @ardatan, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM
yaacovCR commented 1 month ago

I think this should be closed within v17 by #3812 and $4209, so I am going to close this old PR in the name of tidying up, feel free to reopen.

See also: https://github.com/graphql/graphql-js/issues/4085#issuecomment-2385360079