search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
20.04k stars 2.02k forks source link

incremental: remove extra ticks #4091

Closed yaacovCR closed 4 months ago

yaacovCR commented 4 months ago

consolidates some defer payloads

This is accomplished by replacing a promised result within a DeferredGroupedFieldSetRecord with the actual result as soon as possible, so that IncrementalPublisher doesn't wait an extra tick if it doesn't need to.

This same optimization can also be employed with StreamItemsRecords, but it is possible that the stream logic should be overall reworked.

netlify[bot] commented 4 months ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 38df4ea6972cb8f7666a8a6916bc099499a3cf3b
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6644dbdc55443800087ca288
Deploy Preview https://deploy-preview-4091--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 4 months ago

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM
yaacovCR commented 4 months ago

This has been reworked and is now part of #4094