search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
19.97k stars 2k forks source link

incremental: always only emit single completion error for deferred fragment #4092

Closed yaacovCR closed 1 month ago

yaacovCR commented 1 month ago

When multiple deferred grouped field sets within a fragment error causing the fragment to complete in error, only a single completion error should be emitted.

netlify[bot] commented 1 month ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 0e8830e213e3a083c073d8ab9935cfccf1f2cb6a
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66457a2c6ff14b00084ab638
Deploy Preview https://deploy-preview-4092--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM
yaacovCR commented 1 month ago

Fix for this, and the corresponding test has been integrated into #4094