search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
19.97k stars 2k forks source link

Update release instructions in CONTRIBUTING.md #4105

Closed benjie closed 3 weeks ago

benjie commented 3 weeks ago

npm publish npmDist fails:

$ npm publish npmDist                  
npm ERR! code E404                                                            
npm ERR! 404 Not Found - GET https://registry.npmjs.org/npmDist - Not found                                                                                                                    
npm ERR! 404                                                                  
npm ERR! 404  'npmDist@*' is not in this registry.                            
npm ERR! 404 This package name is not valid, because                                                                                                                                           
npm ERR! 404  1. name can no longer contain capital letters                   
npm ERR! 404                                                                  
npm ERR! 404 Note that you can also install from a                            
npm ERR! 404 tarball, folder, http url, or git url.

However cd npmDist && npm publish works.

I've also fixed the releases URL, and added the npm run changelog command with final instruction.

netlify[bot] commented 3 weeks ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 7c0377643a6eb89093f293ac7b9545890a15251c
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6669b3987e12160008913a0a
Deploy Preview https://deploy-preview-4105--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 weeks ago

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM
benjie commented 3 weeks ago

We should probably also note somewhere that the releasing user needs to have Docker installed and docker run hello-world should work without error.