search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
19.97k stars 2k forks source link

polish(incremental): remove id mutation #4107

Closed yaacovCR closed 2 weeks ago

yaacovCR commented 3 weeks ago

depends on #4106

netlify[bot] commented 3 weeks ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit 68fa5ab33335db9189f2ecb7310e3b49859a3575
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66731759a13aad0008de1ae7
Deploy Preview https://deploy-preview-4107--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 weeks ago

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM
yaacovCR commented 2 weeks ago

As discussed with @robrichard offline, will drop this in favor of assigning ids sequentially during execution, even though if early execution is enabled, this means that ids might be delivered out of order or even never sent (when results are filtered). Will submit that in a separate PR.