search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
20.04k stars 2.02k forks source link

fix(incremental): properly initiate nested deferred grouped field sets #4109

Closed yaacovCR closed 2 months ago

yaacovCR commented 3 months ago

when early execution is disabled, the shouldDefer logic has a subtle bug

see: https://github.com/graphql/defer-stream-wg/discussions/84#discussioncomment-8280294

depends on #4112

netlify[bot] commented 3 months ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit a5e24f081c6721204219a9bf92e8515d2a7cb262
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6685a7dd5c09f10008a56c3c
Deploy Preview https://deploy-preview-4109--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 months ago

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM
yaacovCR commented 2 months ago

Closing in favor of https://github.com/graphql/graphql-js/pull/4140