search

graphql / graphql-js

A reference implementation of GraphQL for JavaScript
http://graphql.org/graphql-js/
MIT License
20.1k stars 2.03k forks source link

fix(incremental): do not initiate non-pending execution groups #4140

Closed yaacovCR closed 4 months ago

yaacovCR commented 4 months ago

Currently, when early execution is disabled, we still use the early execution logic to initiate execution groups, which may cause early initiation of non-pending execution groups.

alternative to #4109, causes potentially stacking delays when combinations of shared and non-shared keys between sibling defers cause separate deferred grouped field sets for the same deferred fragment.

netlify[bot] commented 4 months ago

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
Latest commit aac351951b1da7f8134b367d461167e4dd468841
Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6685a71d3f2f3b00080fdb3c
Deploy Preview https://deploy-preview-4140--compassionate-pike-271cb3.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 4 months ago

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands Please post this commands in separate comments and only one per comment: * `@github-actions run-benchmark` - Run benchmark comparing base and merge commits for this PR * `@github-actions publish-pr-on-npm` - Build package from this PR and publish it on NPM