graphql / graphql-playground

🎮 GraphQL IDE for better development workflows (GraphQL Subscriptions, interactive docs & collaboration)
MIT License
8.77k stars 735 forks source link

Change the default of request.credentials #1192

Open kevinsimper opened 4 years ago

kevinsimper commented 4 years ago

This issue pertains to the following package(s):

The default value of request.credentials is "omit". The differs from the default of Fetch changed so that it is same-site.

https://github.com/whatwg/fetch/pull/585

It confuses when cookies is used for authorization.

Could it be changed to same-site?

martin-888 commented 4 years ago

Yes please, I just spent 2 hours with debugging code because of it. And it's happening with my every new project when I forget about it..

kevinsimper commented 4 years ago

Yeah I also spent a bit debugging 😅