fix: cdn url - Githubissues

graphql / graphql-playground

🎮 GraphQL IDE for better development workflows (GraphQL Subscriptions, interactive docs & collaboration)

MIT License

8.77k stars 735 forks source link

fix: cdn url #1238

Closed tgroutars closed 4 years ago

tgroutars commented 4 years ago

Removes / character in url that shouldn't be there.

CLAassistant commented 4 years ago

All committers have signed the CLA.

hemal7735 commented 4 years ago

Hello @acao, could you help to review this PR?

wyattjoh commented 4 years ago

☝️ Umm, looks like this shouldn't have happened....

jedwards1211 commented 4 years ago

This needs to be released

jedwards1211 commented 4 years ago

I'm very confused, how is GraphQL Playground not broken for 100% of users right now because of this issue?

acao commented 4 years ago

hey folks! I'm not sure how this PR got closed either. looks like you can automatically close issues from other repos which doesnt seem like something that should happen

I've been maintaining this as a hobby effort, since i'm mostly focused on graphiql and vscode-graphql for work, and i just got back from vaction. We were supposed to freeze this repo a while ago, if you didn't see the article, but there are just never ending bugs. I'm gonna spend some time on it tonight and see if we can't get a few more fixes in.

acao commented 4 years ago

@jedwards1211 it's only broken if they specify version

jedwards1211 commented 4 years ago

Yeah, I figured that out finally and opened an issue about it, and closed it once this got merged