🎮 GraphQL IDE for better development workflows (GraphQL Subscriptions, interactive docs & collaboration)
8.77k
stars
735
forks
source link
fix(graphql-playground-html): inside render-playground-page.ts removed '/' from packageName and version #1255
Closed
Stradivario closed 4 years ago
Issue
Description
Removed incorrect dash
/
betweenpackageName
andversion
tagType of change
Notes
When i am using the last version
patch
ofgraphql-playground-html
i get response from the browser sayinghttps://cdn.jsdelivr.net/npm/graphql-playground-react/@1.7.1/build/static/css/index.css
Also the same situation is for
js
bundlehttps://cdn.jsdelivr.net/npm/graphql-playground-react/@1.7.1/build/static/js/middleware.js
What i have found out is that
buildCDNUrl
function has oneslash
more at the url so instead ofWe should have
Maybe it is hard to notice but between ${packageName} and ${version...} we have
/
which is not correcturl
Correct URL:
Incorrect URL: