Fix Electron build

[vardhanapoorv]

Fixes #1273 .

Changes proposed in this pull request:

• Upgrade electron-builder, electron-devtools-installer & webpack-dev-server packages.

• Fix Babel config.

[acao]

thanks so much for working on this @vardhanapoorv ! hoping to finally check this out this weekend and give it a local run through

[vardhanapoorv]

That's great!

[acao]

wasn't able to get it running last weekend, hopefully I can get to it tonight!

[vardhanapoorv]

@acao Let me know if anymore changes are needed, when you get a chance to review it.

[acao]

@vardhanapoorv nice! it works in terms of fixing the initial schema choice screen

on yarn start, once I supply a remote endpoint though, i get a blank screen and this error

[vardhanapoorv]

@acao I build it using npm run build and then tested release app with npm run release:mac before.

[vardhanapoorv]

@acao just tested with yarn start that also seems to be working for me. Let me know if I'm doing something wrong here.

[acao]

so, when I run yarn after cloning your PR, the yarn.lock file is very different. so this might be why its not working here or in CI. If you're able to submit a PR with a clean lockfile then we can move forward! by that i mean, when I run yarn locally after checking out your PR, there should be no change to yarn.lock.

to try and simulate the situation I'm having, try cloning this repo into a new folder, and running yarn, and trying the above commands, and you'll see the lockfile diff and other issues I'm talking about

what that indicates to me is that the node_modules you have locally are working, but whats in the yarn.lock and in the package.json files is not adding up

[vardhanapoorv]

@acao oh yeah right makes sense, thanks. This reminds me that I was facing some issue with global lockfile so I installed the dependencies for electron package from there which created a separate lockfile in that folder, which I'm thinking is wrong since no file existed before. I'm a bit confused with the build process of the packages in this repo. After your above comment, I did try a bit but I'm not completely clear if the process I'm following is correct or not. (And yes I face couple of similar errors as you saw). Can you tell me the steps which should be followed? Should I install dependencies from base folder or from the respective packages folder? Then should I build the packages separately from their respective folders(React build worked, but the html build failed for me)? Thanks for helping out.

[linux-foundation-easycla[bot]]

The committers are authorized under a signed CLA.

• :white_check_mark: Apoorv Vardhan (7b8b701840d6ad4b2499817394109d31a6f6ac7a, 0080973a02805b1ea397c93994e97faddea216bd, 4b6f6347bc8b3f177e5453b7812ca7b76d735885, 4396c351952a9af44220e302193d7c5589cedc52, c99c84d7c93fa5c4d6f5809266f1f82519a70df3)

[vardhanapoorv]

@acao please ignore the above questions, I actually managed to update it correctly I think. Take a look and let me know if you still face any errors.

[acao]

awesome! also, can you sign the CLA for GraphQL Foundation? this is a new thing now that playground is a GraphQL Foundation project, instead of Prisma's CLA bot.

[vardhanapoorv]

Done!

[acao]

@vardhanapoorv it works great for me locally! excellent work. not easy to deal with all these package resolutions!

[vardhanapoorv]

@vardhanapoorv it works great for me locally! excellent work. not easy to deal with all these package resolutions!

That's great, thanks for helping me out with my questions throughout this issue!

[acao]

@vardhanapoorv glad to help! the contribution effort is very welcome! if you'd like to help accelerate the follow up, here's what I had in mind for next:

• upgrade codemirror-graphql
• upgrade electron
• add electron build to Github Releases using atlassian changesets and github actions

[vardhanapoorv]

Absolutely, sounds good. I can tackle these next. As a separate PR right?

[acao]

@vardhanapoorv yes! separate PR for sure. I will merge this one now. Again, thanks so much!