graphql / swapi-graphql

A GraphQL schema and server wrapping SWAPI.

MIT License

1.04k stars 274 forks source link

Broken starship connection #137

Closed rdickert closed 4 years ago

rdickert commented 6 years ago

Looks like there's a regression: This query used to work but now returns error No entry in local cache for [object Object]

b0a73b6 Seems to be ok, so it happened at some point since then

rdickert commented 6 years ago

This query is ok. It looks like some or all of the non-relay-spec fields are failing, but the edges/node path is ok. It's really useful to have the non-relay ones when first showing people graphql. I use these examples in training, which is why I noticed this!

IvanGoncharov commented 6 years ago

@rdickert Thanks for reporting 👍 I will try to fix it ASAP.

IvanGoncharov commented 6 years ago

@rdickert Fixed in 29ec1bcc0ff626372b086a59c98d3bc3ab33bd55 Query from your initial post is working now.

I will keep this issue until I add new test cases to prevent similar regressions in future.

rdickert commented 6 years ago

Awesome, thanks @IvanGoncharov

eaparnell commented 4 years ago

Or this query. It returns No entry in local cache for http://swapi.dev/api/people/?page=2. Seems like it should work.

galactose commented 4 years ago

I came here with the same issue as @GeneYoung1230 with the issue in the book.

saheljalal commented 4 years ago

Yeah I'm seeing the same error for any query other than { allFilms } unfortunately.

tapayne88 commented 4 years ago

I think I have a fix for this (very crude fix) that works for me™️. Borrowed a lot from #175 which looked to be on the right track.

https://github.com/tapayne88/swapi-graphql/tree/local-cache-entry-fix

Make sure to remove the cache file if you have it and re-download it, something like this should do it

rm -f cache/data.json && yarn download

mahmoudtokura commented 4 years ago

I am getting this error no matter the query I do. Please help. "No entry in local cache for http://swapi.dev/api/people/?page=2", query here