feat: upgrade graphql-config, language server

graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)

https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql

MIT License

555 stars 71 forks source link

feat: upgrade graphql-config, language server #184

Closed acao closed 4 years ago

acao commented 4 years ago

TODO

[x] upgrade graphql-config and graphql-language-service-server
[x] load graphql config/schema using @3 API
[x] update readme
[x] enable jsx/tsx/ts language features (before only highlighting was enabled, except for .js)
[x] headers and env
[x] get operations working with new endpoints extension (default to schema url if provided)
[x] improve error handling for requests
[x] variables validation for requests
[x] remove requirement for typescript LSP extension

resolves #124 #145 #171 #165 #116 #184 requires: https://github.com/graphql/graphiql/pull/1616

UPDATE: you can provide feedback for the graphql.graphql-vscode-insiders extension 0.3.5 to test this PR and it's dependent releases in #184

acao commented 4 years ago

oops this was supposed to be a draft haha

matt-huh commented 4 years ago

Any update to this PR? I'm waiting for days...

acao commented 4 years ago

@matt-huh whole days, huh? welcome to OSS! :laughing:

still working on several required PRs to the LSP server that this depends on. will need to publish about 24 new NPM package versions before I can even finish this PR. this branch is what I used for reference while developing the LSP changes.

also i have auncle duties, as a new generation just entered this world yesterday, so please bear with me, there will be delays as I have family commitments

matt-huh commented 4 years ago

@acao Thanks for sharing the status. I'm always grateful for all the great contributions made - no intention to push!

acao commented 4 years ago

good news folks! this is very close. close enough to test with just a few steps

prisma folks and I are still working out a few details, and deciding whether/how to pre-release this, or whether to just issue a full stable release. I still need to finish updating the prisma graphql config extension that this depends on.

testing instructions:

clone this repo, check out this branch chore/graphql-config-3
npm install
open in vscode
open debugger tab, run "Run (Extension)"
in the vscode window that opens, now open a graphql project with a graphql-config@3 config

config migration tips:

schemaPath -> schema
includes -> documents
use .js and process.env instead of funky old yaml env template replacement, etc.

Note that you need extensions.endpoints as before, or at least one url in schema entry.

I think the documentation could use more information, and that it would be nice to start a changelog with this PR

acao commented 4 years ago

good news!

you can install a pre-release from the marketplace now:

https://github.com/prisma-labs/vscode-graphql/issues/181#issuecomment-672337523

huv1k commented 4 years ago

I am getting a lot of errors, what is the best way to provide feedback? Like this for example:

acao commented 4 years ago

@huv1k let's provide feedback here #181. try 0.3.5 update and a reload!