search

graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)
https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql
MIT License
557 stars 71 forks source link

feat: add restart option to vscode-graphql command pallate #186

Closed twmillett closed 4 years ago

twmillett commented 4 years ago

As a small workaround for Does not work when updating the schema and from this suggestion:

This PR proposes a command to restart the gql plugin. So, instead of restarting vs-code, a user can do ctrl-shift-p to pull up the Command Palette and type something like "graphql restart".

It's not great, but as the cantiero indicates, "Beats restarting the editor for sure".

acao commented 4 years ago

thanks for reporting this!

we are working on upgrading the underlying graphql-language-service-server which addresses this problem, however there are a few breaking changes in gls-server@2.4.x and at least one regression from dropping watchman as well.

now that i'm a maintainer, i will disable this semantic pull request business, haha!

twmillett commented 4 years ago

we are working on upgrading the underlying graphql-language-service-server which addresses this problem, however there are a few breaking changes in gls-server@2.4.x and at least one regression from dropping watchman as well.

now that i'm a maintainer, i will disable this semantic pull request business, haha!

I'm totally happy to fulfill the tool's requirements. Do I just add another commit with "feat" in the message?

Totally love the plugin -- the best out there that I could find. Will be awesome to see the upgrade to the next language server :-)

acao commented 4 years ago

looks good to go, thank you @twmillett !