graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)
https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql
MIT License
555 stars 71 forks source link

File "glob" patterns don't work for `schema` config pointers #239

Closed acao closed 2 years ago

acao commented 4 years ago

Actual Behavior

schema: "src/schema/**/*.ts"
extensions:
  languageService:
    useSchemaFileDefinitions: true

Expected Behaviour

schema: "src/schema/**/*.ts"
extensions:
  languageService:
    useSchemaFileDefinitions: true

should lead to all files in src/schema loading with SDL definition entries

Steps to Reproduce the Problem Or Description

schema: "src/schema/**/*.ts"
extensions:
  languageService:
    useSchemaFileDefinitions: true

Specifications

Fix

The fix involves using something like fast-glob to detect graphql config glob paths and parse and cache the files in our custom implementation. the implementation only needs to happen in one place, too!

ibratoev commented 3 years ago

It would be great to get this fixed! Open for contribution?

acao commented 2 years ago

fixed! let me know how it is and if it needs re-opened