graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)
https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql
MIT License
555 stars 71 forks source link

Show the output channel when clicking on graphql status bar #436

Closed orta closed 2 years ago

orta commented 2 years ago

As knowing whether you are in debug or not isn't too useful from a users perspective

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 5554f5498087228e04b366fe134bc67560072020

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | vscode-graphql | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

acao commented 2 years ago

Great idea! Not sure why the changeset isn’t picking up, I’ll look into it later

acao commented 2 years ago

@orta if you bump graphql-language-service-server when you rebase this, then you'll have the LSP improvements as well! or a seperate PR for that, your choice

orta commented 2 years ago

Makes sense, bumped the version!

acao commented 2 years ago

I think I introduced conflicts via merging a dependabot PR, oof

orta commented 2 years ago

( It says it has no conflicts to me )

acao commented 2 years ago

maybe it’s a cacheing issue? Or a github bug? I see this on both my phone and desktop… hmm!!

0C73CC2B-FCC5-4771-9148-560FC15D3F4E

orta commented 2 years ago

image

hah

orta commented 2 years ago

maybe that's merge vs rebase., will try do it manually anyway

acao commented 2 years ago

thank you! that was so weird, still not sure what happened haha

acao commented 2 years ago

@orta I don't know why but the Version Packages PR isn't being created by changsets :((

orta commented 2 years ago

heh, sounds to me like a lot of annoying automation on this repo. At least it won't be for long

acao commented 2 years ago

Yup! Working on that PR now

we should make a nice graphic for the monorepo readme to explain what is what, and how vscode-graphql and graphiql are sharing the internal LS dependencies. The one i have now seems to scare people! Haha

acao commented 2 years ago

I originally added changesets here because it used to deploy on every merge which was a huge problem. Semantic release wouldve been better in retrospect, especially with the auto-comment-with-release-version-and-close tickets feature. This would save so much time with releases

Also tried setting up prerelease, but at least when they introduced it and the vscode PM reached out to me to use it, it didn’t support semver prerelase notation? So vscode prerelease at least a few months ago didnt support prerelease version notation like rc or beta