Closed orta closed 2 years ago
Latest commit: 5554f5498087228e04b366fe134bc67560072020
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Great idea! Not sure why the changeset isn’t picking up, I’ll look into it later
@orta if you bump graphql-language-service-server
when you rebase this, then you'll have the LSP improvements as well! or a seperate PR for that, your choice
Makes sense, bumped the version!
I think I introduced conflicts via merging a dependabot PR, oof
( It says it has no conflicts to me )
maybe it’s a cacheing issue? Or a github bug? I see this on both my phone and desktop… hmm!!
hah
maybe that's merge vs rebase., will try do it manually anyway
thank you! that was so weird, still not sure what happened haha
@orta I don't know why but the Version Packages PR isn't being created by changsets :((
heh, sounds to me like a lot of annoying automation on this repo. At least it won't be for long
Yup! Working on that PR now
we should make a nice graphic for the monorepo readme to explain what is what, and how vscode-graphql and graphiql are sharing the internal LS dependencies. The one i have now seems to scare people! Haha
I originally added changesets here because it used to deploy on every merge which was a huge problem. Semantic release wouldve been better in retrospect, especially with the auto-comment-with-release-version-and-close tickets feature. This would save so much time with releases
Also tried setting up prerelease, but at least when they introduced it and the vscode PM reached out to me to use it, it didn’t support semver prerelase notation? So vscode prerelease at least a few months ago didnt support prerelease version notation like rc or beta
As knowing whether you are in debug or not isn't too useful from a users perspective