graphql / vscode-graphql

MIGRATED: VSCode GraphQL extension (autocompletion, go-to definition, syntax highlighting)
https://marketplace.visualstudio.com/items?itemName=Prisma.vscode-graphql
MIT License
557 stars 71 forks source link

Add warning to readme that this plugin does not work #94

Closed steida closed 4 years ago

steida commented 5 years ago

To save people time.

https://github.com/prisma/vscode-graphql/issues/93 https://github.com/prisma/vscode-graphql/issues/89 https://github.com/prisma/vscode-graphql/issues/88 https://github.com/prisma/vscode-graphql/issues/87

Thank you.

steida commented 5 years ago

Meanwhile, this extension works for me: https://github.com/kumarharsh/graphql-for-vscode

Just npm install @playlyfe/gql --dev and then the extension itself.

https://github.com/kumarharsh/graphql-for-vscode#a-minimal-example

steida commented 5 years ago

But import somehow sucks, it imports everything and then warns about clashes. Without importing from generated prisma schema, it works.

MichalLytek commented 5 years ago

@steida Does kumarharsh/graphql-for-vscode works for you with the newest graphql-js v14? 😕

steida commented 5 years ago

@19majkel94 It looks like it works.

MichalLytek commented 5 years ago

@steida It doesn't work for me:

image

[Info  - 12:23:52 PM] NODE_PATH value is: f:\#Projekty\#JS\graphql-resolvers
[Info  - 12:23:53 PM] Module '@playlyfe/gql' loaded from: f:\#Projekty\#JS\graphql-resolvers\node_modules\@playlyfe\gql\lib\index.js
{
  "private": true,
  "scripts": {
    "dev": "ts-node-dev --respawn ./src/index.ts"
  },
  "dependencies": {
    "@types/graphql": "^14.0.3",
    "apollo-server": "^2.3.1",
    "graphql": "^14.0.2",
    "typescript": "^3.2.2"
  },
  "devDependencies": {
    "@playlyfe/gql": "^2.6.1",
    "ts-node-dev": "^1.0.0-pre.32"
  }
}

But it still works great in my very old project that has "graphql": "^0.11.7", and "@playlyfe/gql": "^2.4.0",.

MichalLytek commented 5 years ago

@steida It doesn't understand newer syntax:

image

image

But at least I've managed to run it - it was the best extension year ago but it needs an update.

divyenduz commented 5 years ago

@steida : Thanks for raising this. I will take a look at this soon, I already commented on the 4 issues you mentioned here asking for more information or suggesting resolutions. Thanks!

5achinJani commented 5 years ago

75

acao commented 4 years ago

all the issues noted have been fixed, or resolutions have been provided.

please open new tickets if you have issues with the latest versions! thanks!