Closed myrho closed 10 months ago
Still there are issues for eth and tokens. I'm on it.
Pretty nice cleanup! I just think we should consistently name the currency/network parameter either currency
or network
. Now we have both which might be confusing.
@myrho I agree, i think over time we should switch to the name network, but its true that it might be confusing.
Would you like to align the naming for now?
no lets rename the parameter network to currency and to the alignment outside of the context of this hotfix
I have reviewed the changes. Looks good to me but its hard to test with complex cases with many transactions. I tried to add some more (edge) cases to the test suite.
Changes:
@myrho please have another look at the changes, esp. the merging logic. It might be worthwile to add some comments to explain and comment the code since its rather complex (esp. the loop in list_txs_ordered, and the parameters of the functions).