Closed ghost closed 2 years ago
Right now I've chosen to create a second Mapping. An alternative approach (and more efficient) would be to create a single container_meta Mapping that looks something like
{
container_name: {
image: container_image_id
version: container_version
}
}
The tradeoff here is between verbosity (every affected line in Nomad would be longer) and efficiency
Base: 39.24% // Head: 39.21% // Decreases project coverage by -0.02%
:warning:
Coverage data is based on head (
c8305fa
) compared to base (3bb3f51
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Which issue does this PR correspond to?
Fixes https://github.com/grapl-security/issue-tracker/issues/1051
What changes does this PR make to Grapl? Why?
This sets the service.version tag at the service level instead of the job level. As Grapl only rebuilds and tags containers that have changes, the versions for each service within a job are not the same.
How were these changes tested?
Tests