search

grappa-py / grappa

Behavior-oriented, expressive, human-friendly Python assertion library for the 21st century
http://grappa.rtfd.io
MIT License
134 stars 15 forks source link

Fix collections.abc deprecation warning by using six.moves.collections_abc #56

Closed jdlourenco closed 4 years ago

jdlourenco commented 4 years ago

Fixes https://github.com/grappa-py/grappa/issues/47

Uses six.moves.collections_abc module for importing classes that moved to the collections.abc module on python3.

jdlourenco commented 4 years ago

Hey @h2non the travis build is only failing for python 3.3 and 3.4 which are no longer supported.

Travis seems to not be able to download python 3.3 and PyYAML seems to no longer be available for python 3.4

What do you think about removing the python 3.3 and 3.4 jobs from travis?

jdlourenco commented 4 years ago

About python 3.3, this seems to fix it in case you want to keep it: https://github.com/travis-ci/travis-ci/issues/9133#issuecomment-531022359

jdlourenco commented 4 years ago

@h2non the build seems to be failing now due to this bug that can be fixed by bumping flake8 version.

Do you want to do this here or in another PR?

h2non commented 4 years ago

Here it is fine.

jdlourenco commented 4 years ago

Ok, let me push some fixes to flake8 warnings.

h2non commented 4 years ago

Thank you! New release coming soon tomorrow.

h2non commented 4 years ago

Version 0.1.12 is now on the PyPI registry! https://pypi.org/project/grappa/