search

grasenhiller / silverstripe-wkhtmltox

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

Avoid Deprecation notice #5

Closed altwohill closed 5 months ago

altwohill commented 2 years ago

This PR avoids the deprecation notice "Required parameter $type follows optional parameter $variables in src/WkFile.php on line 173"

sirjeff commented 2 years ago

This PR avoids the deprecation notice "Required parameter $type follows optional parameter $variables in src/WkFile.php on line 173"

Yes I can confirm the fix on line 173 works for :

SS 4.10.0 PHP 8.0.0

@gheggie @bhofstaetter Is this project active?

sirjeff commented 10 months ago

@gheggie @bhofstaetter Ping!