Update Usage with relative paths; added cPanel example

grasmash / composerize-drupal

Convert a non-Composer-managed Drupal application (e.g., one created via tarball) to a Composer-managed Drupal application.

MIT License

125 stars 20 forks source link

Update Usage with relative paths; added cPanel example #20

Closed simon-olsen closed 5 years ago

simon-olsen commented 5 years ago

Your composerize-drupal has worked really well. The only thing I found is if I just used the directory name for --drupal-root then my composer.json prefixed all my Drupal directory paths with ../.

Example...

"installer-paths": {
            "drush/Commands/{$name}": [
                "type:drupal-drush"
            ],
            "../public_html/core": [
                "type:drupal-core"
            ],
            "../public_html/modules/contrib/{$name}": [
                "type:drupal-module"
            ],
            ...

When I used a relative path (ie. added ./ to my --drupal-root), the composer.json file was created with the correct paths to my Drupal directory.

So thought I'd suggest updating your usage instructions with this info.

I also added another example for those of us (stuck) using cPanel.

Hope this helps. :)

coveralls commented 5 years ago

Coverage remained the same at 93.173% when pulling 7daf340901c9642d70f680642e6f905f6f0b92ed on simon-olsen:patch-1 into 6c2096a63d4ed4c2a395a111a774fb33a1b442cd on grasmash:master.

coveralls commented 5 years ago

Coverage remained the same at 93.173% when pulling 7daf340901c9642d70f680642e6f905f6f0b92ed on simon-olsen:patch-1 into 6c2096a63d4ed4c2a395a111a774fb33a1b442cd on grasmash:master.

coveralls commented 5 years ago

Coverage remained the same at 93.173% when pulling 7daf340901c9642d70f680642e6f905f6f0b92ed on simon-olsen:patch-1 into 6c2096a63d4ed4c2a395a111a774fb33a1b442cd on grasmash:master.

coveralls commented 5 years ago

Coverage remained the same at 93.173% when pulling 7daf340901c9642d70f680642e6f905f6f0b92ed on simon-olsen:patch-1 into 6c2096a63d4ed4c2a395a111a774fb33a1b442cd on grasmash:master.

grasmash commented 5 years ago

What operating system are you using?

I'm happy to merge this as a stop gap, but ideally I'd like to not required a "." prefix. Will need to update code and tests.

simon-olsen commented 5 years ago

I'm on Mac (Mojave and High Sierra).